-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save image with specified format #988
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code itself looks very neat overall.
The |
Thanks for the feedback! 😄 I made the changes to the docs, and exposed the |
Great work, thank you. Want to join |
Ran into the use case where I wanted to save an image without specifying the file extension in the filename. This PR lets you do just that:
I'm not sure if this is a wanted addition or not, so I'm mostly looking for feedback.
I used the
image::ImageFormat
enum for accepting formats. This enum doesn't includepbm
,pgm
,ppm
, andpam
, so I left those out as I'm not familiar enough with the library to make changes to the enum. Alternatively we can just make another enum.I license past and future contributions under the dual MIT/Apache-2.0 license,
allowing licensees to chose either at their option.